Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] FExpr Trigonometric #3454

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ENH] FExpr Trigonometric #3454

wants to merge 2 commits into from
+242 −201

Conversation

samukweku
Copy link
Contributor

@samukweku samukweku self-assigned this Apr 3, 2023
@oleksiyskononenko
Copy link
Contributor

@samukweku I suggest we fix all the issues with the existing PRs and make them green, before opening new ones. Otherwise, it is complicated to keep track of all of them.

@samukweku
Copy link
Contributor Author

@oleksiyskononenko all good; I'll wait for your feedback on the other PRs

@oleksiyskononenko
Copy link
Contributor

@samukweku I'm off this week, but it is better to make PRs green first.

@samukweku samukweku force-pushed the samukweku/trigonometric_fexpr branch from 0dc72a5 to 6cd4f71 Compare April 11, 2023 10:49
@samukweku
Copy link
Contributor Author

@oleksiyskononenko since i've got some time, I'll work on some more issues, and mark them as draft, pending when the other PRs are reviewed.

@oleksiyskononenko
Copy link
Contributor

@samukweku some PRs are still red, you might want to take a look at them.

@samukweku samukweku force-pushed the samukweku/trigonometric_fexpr branch from 6cd4f71 to 463c0d8 Compare April 20, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksiyskononenko oleksiyskononenko Awaiting requested review from oleksiyskononenko

At least 1 approving review is required to merge this pull request.

Assignees

@samukweku samukweku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samukweku @oleksiyskononenko